[ 
https://issues.apache.org/jira/browse/NIFI-12513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799917#comment-17799917
 ] 

Daniel Stieglitz edited comment on NIFI-12513 at 12/22/23 7:40 PM:
-------------------------------------------------------------------

[~exceptionfactory] [~pvillard] I have developed a utility method which now 
uses a regular expression to parse the 7 parts of the URI and instantiates a 
URI object with those seven pieces as I had suggested earlier. I modified the 
StandardValidators#URL_VALIDATOR and InvokeHttp (when creating the java.net.URI 
object from the value entered in the 'HTTP_URL' property)  to now use the 
utility method. My question is where else would this change apply? What other 
places that are currently using URI.create would pose a problem since there be 
unquoted/unescaped characters in its query and/or fragments sections? I am not 
sure all of the places changed in 
[#7771|https://github.com/apache/nifi/pull/7771] need this since they may not 
have any characters which need to be quoted/escaped.


was (Author: JIRAUSER294662):
[~exceptionfactory] [~pvillard] So I have developed a utility method which now 
uses a regular expression to parse the 7 parts of the URI and instantiates a 
URI object with those seven pieces as I had suggested earlier. I modified the 
StandardValidators#URL_VALIDATOR and InvokeHttp (when creating the java.net.URI 
object from the value entered in the 'HTTP_URL' property)  to now use the 
utility method. My question is where else would this change apply? What other 
places that are currently using URI.create would pose a problem since there be 
unquoted/unescaped characters in its query and/or fragments sections? I am not 
sure all of the places changed in 
[#7771|https://github.com/apache/nifi/pull/7771] need this since they may not 
have any characters which need to be quoted/escaped.

> Regression in InvokeHTTP - Not a valid URL
> ------------------------------------------
>
>                 Key: NIFI-12513
>                 URL: https://issues.apache.org/jira/browse/NIFI-12513
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: 2.0.0-M1, 1.24.0
>            Reporter: Pierre Villard
>            Assignee: Daniel Stieglitz
>            Priority: Major
>
> On NiFi 1.24 and NiFi 2.0-M1, the below URL
> {code:java}
> https://en.wikipedia.org/w/api.php?action=query&list=recentchanges&format=json&rcprop=user|comment|parsedcomment|timestamp|title|sizes|tags{code}
> Is no longer considered as valid but it was a valid one before.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to