ravinarayansingh commented on code in PR #7544:
URL: https://github.com/apache/nifi/pull/7544#discussion_r1437177360
##########
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UpdateDatabaseTable.java:
##########
@@ -460,15 +488,18 @@ public void onTrigger(final ProcessContext context, final
ProcessSession session
private synchronized OutputMetadataHolder checkAndUpdateTableSchema(final
Connection conn, final DatabaseAdapter databaseAdapter, final RecordSchema
schema,
final
String catalogName, final String schemaName, final String tableName,
- final
boolean createIfNotExists, final boolean translateFieldNames, final boolean
updateFieldNames,
+ final
boolean createIfNotExists, final boolean translateFieldNames,
+ final
TranslationStrategy translationStrategy, Pattern translationRegex, final
boolean updateFieldNames,
final
Set<String> primaryKeyColumnNames, final boolean quoteTableName, final boolean
quoteColumnNames) throws IOException {
// Read in the current table metadata, compare it to the reader's
schema, and
// add any columns from the schema that are missing in the table
+// final ColumnNameNormalizer normalizer = new
ColumnNameNormalizer(translateFieldNames, translationStrategy,
translationRegex);
Review Comment:
i have removed the commented code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
