EndzeitBegins commented on PR #82:
URL: https://github.com/apache/nifi-site/pull/82#issuecomment-1876400123

   Thank you for your work on this @james-elliott, @exceptionfactory  and all 
others who contributed. The new page looks refreshing.
   
   I haven't looked at the code changes but rather on the staged version of the 
website and noticed a small area of improvement on the mobile view.
   
   When looking at the embedded documentation (both 1.24.0 and 2.0.0-M1), the 
actual documentation takes only about half of the screens height, while the 
other half is taken by the headers of the site and the documentation. 
   
![Screenshot_20240104-064151~2](https://github.com/apache/nifi-site/assets/16666115/bf512b3f-0a2f-4cf6-8df5-ad81b85886aa)
   
   I think this is less a problem of the updated site per se but rather how the 
header of the rendered documentation behaves on mobile view. I don't know how 
the documentation is render, but maybe we rather want to have some sort of 
collapsible header for the mobile view in order to increase the visual space 
available for the documentation's content.
   
   Maybe that's something we want to improve on in the future. However, that 
shouldn't keep us from releasing the updated site. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to