martinzink commented on code in PR #1698:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1698#discussion_r1418662196
##########
cmake/MiNiFiOptions.cmake:
##########
@@ -122,6 +122,7 @@ add_minifi_option(ENABLE_KUBERNETES "Enables the Kubernetes
extensions." ON)
add_minifi_option(ENABLE_TEST_PROCESSORS "Enables test processors" OFF)
add_minifi_option(ENABLE_PROMETHEUS "Enables Prometheus support." ON)
add_minifi_option(ENABLE_GRAFANA_LOKI "Enable Grafana Loki support" OFF)
+add_minifi_option(ENABLE_GRPC "Enable gRPC for Grafana Loki extension" ON)
Review Comment:
ENABLE_GRPC seems a bit too generic since GRPC can be used for a lot of
other things.
##########
CMakeLists.txt:
##########
@@ -352,6 +356,10 @@ if (ENABLE_ALL OR ENABLE_PROMETHEUS OR NOT DISABLE_CIVET)
list(APPEND CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/cmake/civetweb/dummy")
endif()
+if (ENABLE_ALL OR ENABLE_GCP OR ENABLE_GRAFANA_LOKI)
+ include(Abseil)
+endif()
Review Comment:
Why do we need this here? Couldnt we include abseil twice? in gcp and
grafana aswell (after the early returns ofcourse), since its a fetchcontent
makeavailable we should be able to call it twice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
