ChrisSamo632 commented on code in PR #8224:
URL: https://github.com/apache/nifi/pull/8224#discussion_r1445755385


##########
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateCsv.java:
##########
@@ -514,8 +514,9 @@ public void process(OutputStream out) throws IOException {
 
                         } catch (final SuperCsvException e) {
                             valid.set(false);
+                            final String errorMessage = 
e.getLocalizedMessage() + " " + e.getCsvContext().toString();

Review Comment:
   Including the raw csv line could mean printing PII/PID or other sensitive 
information to logs, or cause very long log outputs when processing large csv 
files
   
   Should we make the inclusion of the raw csv line optional in this output, 
what do you think?
   
   I agree that printing the coordinates is a really useful addition



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to