martinzink commented on code in PR #1714:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1714#discussion_r1447287013


##########
.github/workflows/verify-python-compatibility.yml:
##########
@@ -82,3 +83,9 @@ jobs:
           output-to: 'step-summary'
           list-tests: 'failed'
           list-suites: 'failed'
+      - name: Upload artifact
+        if: failure()
+        uses: actions/upload-artifact@v3
+        with:
+          name: behavex_output

Review Comment:
   If there are multiple failures, it will overwrite the uploaded files so only 
the last one will remain.
   This might solve this issue (I didnt test it)
   ```suggestion
             name: ${{ matrix.platform.name }}_behavex_output
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to