martinzink commented on code in PR #1706:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1706#discussion_r1447302157


##########
extensions/standard-processors/processors/GenerateFlowFile.h:
##########
@@ -70,14 +66,15 @@ class GenerateFlowFile : public core::Processor {
       .withDefaultValue("Binary")
       .build();
   EXTENSIONAPI static constexpr auto UniqueFlowFiles = 
core::PropertyDefinitionBuilder<>::createProperty("Unique FlowFiles")
-      .withDescription("If true, each FlowFile that is generated will be 
unique. If false, a random value will be generated and all FlowFiles")
+      .withDescription("If true, each FlowFile that is generated will be 
unique. "
+          "If false, a random value will be generated and all FlowFiles will 
get the same content but this offers much higher throughput")

Review Comment:
   All flowfiles period.
   The description is directly from NiFi. And afaik nifi and minifi works in 
the same way so if this is false we only generate the date once. (except if 
CustomText is set then we should evaluate it once per batch)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to