szaszm commented on code in PR #1713:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1713#discussion_r1447508845
##########
README.md:
##########
@@ -154,7 +154,7 @@ and rebuild.
* perl -- Required for OpenSSL configuration
* NASM -- Required for OpenSSL only on Windows
-**NOTE** On Windows if Strawberry Perl is used the
`${StrawberryPerlRoot}\c\bin` directory should not be part of the %PATH%
variable or make sure to find git's patch executable before that as Strawberry
Perl's patch.exe will be found as the patch executable in the configure phase
instead of the git patch executable. Also on Windows CMake's CPack is used for
MSI generation, building WIX files and calling WIX toolset tools to create an
MSI. If Chocolatey package manager is used its CPack can conflict with CMake,
so make sure that CMake's CPack is found in the %PATH% before that.
+**NOTE:** On Windows if Strawberry Perl is used the
`${StrawberryPerlRoot}\c\bin` directory should not be part of the PATH
environment variable. Alternatively make sure that git's patch executable path
comes before Strawberry Perl's patch.exe path in the PATH environment variable,
so that the git patch executable is found in the in the CMake configuration
phase. Also on Windows CMake's CPack is used for MSI generation, building WIX
files and calling WIX toolset tools to create an MSI. If Chocolatey package
manager is used its CPack can conflict with CMake, so make sure that CMake's
CPack is found in the %PATH% before that.
Review Comment:
Confirmed that moving is not enough, removing the path entry either on the
CLI or GUI solves the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
