pvillard31 commented on code in PR #8229:
URL: https://github.com/apache/nifi/pull/8229#discussion_r1452629738
##########
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateCsv.java:
##########
@@ -174,6 +175,19 @@ public class ValidateCsv extends AbstractProcessor {
.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
.build();
+ public static final PropertyDescriptor GET_ALL_VIOLATIONS = new
PropertyDescriptor.Builder()
+ .name("validate-csv-violations")
+ .displayName("Get all violations")
+ .description("If true, the validation.error.message attribute
would contain the list of all the violations"
+ + " for the first invalid line. Note that setting this
property to true would slightly decrease"
+ + " the performances as all columns would be validated. If
false, a line is invalid as soon as a"
+ + " column is found violating the specified constraint and
only this violation for the first invalid"
+ + " line will be indicated in the validation.error.message
attribute.")
+ .required(true)
+ .allowableValues("true", "false")
+ .defaultValue("false")
+ .build();
Review Comment:
I've not looked at all of the codebase but usually a True/False property's
description is starting with a verb. I'm fine using another work like "check"
but I do think a verb should be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
