exceptionfactory commented on code in PR #8249:
URL: https://github.com/apache/nifi/pull/8249#discussion_r1452770561
##########
nifi-nar-bundles/nifi-jolt-bundle/pom.xml:
##########
@@ -57,6 +45,22 @@
<artifactId>json-utils</artifactId>
<version>${jolt.version}</version>
</dependency>
+ <dependency>
+ <groupId>javax.servlet.jsp</groupId>
+ <artifactId>javax.servlet.jsp-api</artifactId>
+ <version>2.3.3</version>
+ </dependency>
+ <dependency>
+ <groupId>javax.ws.rs</groupId>
+ <artifactId>javax.ws.rs-api</artifactId>
+ <version>2.1.1</version>
+ </dependency>
Review Comment:
These dependencies are the old versions that are no longer current following
the upgrade to Spring 6 and Jetty 12. These should be replaced with the new
Jakarta equivalent versions.
##########
nifi-nar-bundles/nifi-standard-bundle/pom.xml:
##########
@@ -101,7 +99,7 @@
<dependency>
<groupId>com.hierynomus</groupId>
<artifactId>sshj</artifactId>
- <version>0.38.0</version>
+ <version>0.37.0</version>
Review Comment:
This change should be reverted.
##########
nifi-nar-bundles/nifi-standard-bundle/pom.xml:
##########
@@ -210,6 +208,33 @@
<artifactId>json-flattener</artifactId>
<version>0.16.6</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.bval</groupId>
+ <artifactId>bval-jsr</artifactId>
+ <version>1.1.2</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.tomcat</groupId>
+ <artifactId>tomcat-el-api</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.apache.geronimo.specs</groupId>
+ <artifactId>geronimo-annotation_1.2_spec</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.apache.geronimo.specs</groupId>
+ <artifactId>geronimo-jcdi_1.1.spec</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.apache.geronimo.specs</groupId>
+ <artifactId>geronimo-jpa_2.0.spec</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.apache.bval</groupId>
+ <artifactId>bval-xstream</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
Review Comment:
This dependency should be removed as it is not used.
##########
nifi-nar-bundles/nifi-standard-bundle/pom.xml:
##########
@@ -80,18 +77,19 @@
<version>2.0.0-SNAPSHOT</version>
</dependency>
<dependency>
- <groupId>com.bazaarvoice.jolt</groupId>
- <artifactId>jolt-core</artifactId>
- <version>${jolt.version}</version>
+ <groupId>javax.servlet.jsp</groupId>
+ <artifactId>javax.servlet.jsp-api</artifactId>
+ <version>2.3.3</version>
</dependency>
<dependency>
- <groupId>com.bazaarvoice.jolt</groupId>
- <artifactId>json-utils</artifactId>
- <version>${jolt.version}</version>
+ <groupId>javax.servlet</groupId>
+ <artifactId>javax.servlet-api</artifactId>
+ <version>3.1.0</version>
</dependency>
<dependency>
- <groupId>jakarta.ws.rs</groupId>
- <artifactId>jakarta.ws.rs-api</artifactId>
+ <groupId>javax.ws.rs</groupId>
+ <artifactId>javax.ws.rs-api</artifactId>
+ <version>2.1.1</version>
Review Comment:
These javax dependencies are no longer current and should be removed.
##########
nifi-nar-bundles/nifi-standard-bundle/pom.xml:
##########
@@ -265,7 +290,7 @@
<dependency>
<groupId>com.networknt</groupId>
<artifactId>json-schema-validator</artifactId>
- <version>1.1.0</version>
+ <version>1.0.87</version>
Review Comment:
This change should be reverted.
##########
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-nar/src/main/resources/META-INF/NOTICE:
##########
@@ -10,7 +10,7 @@ This product includes the following work from the Apache
Hadoop project under Ap
This includes derived works from the Apache Software License V2 library Jolt
(https://github.com/bazaarvoice/jolt)
Copyright 2013-2014 Bazaarvoice, Inc
The derived work is adapted from
com.bazaarvoice.jolt.chainr.ChainrBuilder.java,
com.bazaarvoice.jolt.chainr.spec.ChainrSpec.java,
- com.bazaarvoice.jolt.chainr.spec.ChainrEntry.java and can be found in the
org.apache.nifi.processors.standard.util.jolt.TransformFactory.java class.
+ com.bazaarvoice.jolt.chainr.spec.ChainrEntry.java and can be found in the
util.org.apache.nifi.processors.jolt.TransformFactory.java class.
Review Comment:
This appears to be incorrect and should be reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
