rfellows commented on code in PR #8294: URL: https://github.com/apache/nifi/pull/8294#discussion_r1465526272
########## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/header/flow-status/_flow-status.component-theme.scss: ########## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +@use 'sass:map'; +@use '@angular/material' as mat; + +@mixin theme($theme) { + // Get the color config from the theme. + $color-config: mat.get-color-config($theme); + + // Get the color palette from the color-config. + $primary-palette: map.get($color-config, 'primary'); + $accent-palette: map.get($color-config, 'accent'); + $warn-palette: map.get($color-config, 'warn'); + + // Get hues from palette + $primary-palette-300: mat.get-color-from-palette($primary-palette, 300); + $primary-palette-500: mat.get-color-from-palette($primary-palette, 500); + $primary-palette-contrast-900: mat.get-color-from-palette($primary-palette, '900-contrast'); + $accent-palette-400: mat.get-color-from-palette($accent-palette, 400); + $warn-palette-A400: mat.get-color-from-palette($warn-palette, 'A400'); + + .flow-status { + border-bottom: 1px solid $primary-palette-300; + box-sizing: content-box; + font-size: 15px; + + .fa, + .icon { + font-size: 15px; + font-style: normal; + color: $primary-palette-500; + } + + .status-value { + white-space: nowrap; + font-weight: 500; + color: $warn-palette-A400; + text-shadow: none; + } + + .controller-bulletins { + border-left: 1px solid $primary-palette-300; + background-color: $primary-palette-500; + cursor: default; + } + + .controller-bulletins.has-bulletins { + background-color: $accent-palette-400; Review Comment: this is showing as a green bulletin icon. i think we need: ```suggestion background-color: $warn-light-400; ``` ########## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/pom.xml: ########## @@ -32,6 +32,11 @@ <node.version>v20.5.1</node.version> <frontend.source>${basedir}/src/main/nifi</frontend.source> <frontend.working.dir>${project.build.directory}/frontend-working-directory</frontend.working.dir> + <!-- + String name of the theme file to be used. + Ex: 'purple' // will overwrite the nifi.scss theme file with the 'purple' theme. + --> + <frontend.theme>purple</frontend.theme> Review Comment: This should default to `nifi`. To override during the build, you can just pass in an override to set it (`-Dfrontend.theme=<<theme here>>`)... ``` mvn -T 2 install -Dfrontend.theme=purple -DskipTests -P\!minify-and-compress,avoid-archive-formats,include-new-ui ``` ########## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/access-policies/ui/common/add-tenant-to-policy-dialog/add-tenant-to-policy-dialog.component.html: ########## @@ -42,7 +42,7 @@ <h2 mat-dialog-title>Add Users/Groups To Policy</h2> </div> </mat-dialog-content> <mat-dialog-actions align="end" *ngIf="{ value: (saving$ | async)! } as saving"> - <button mat-raised-button mat-dialog-close color="accent">Cancel</button> + <button mat-raised-button mat-dialog-close color="primary">Cancel</button> Review Comment: we shouldn't have 2 primary buttons on the same dialog. this one should probably be: ```suggestion <button mat-stroked-button mat-dialog-close color="primary">Cancel</button> ``` ########## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/pom.xml: ########## @@ -87,6 +92,27 @@ </execution> </executions> </plugin> + <plugin> + <groupId>com.coderplus.maven.plugins</groupId> + <artifactId>copy-rename-maven-plugin</artifactId> + <version>1.0</version> Review Comment: should probably variablize this version, just to be consistent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
