turcsanyip commented on code in PR #8281:
URL: https://github.com/apache/nifi/pull/8281#discussion_r1466456472
##########
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/storage/PutGCSObject.java:
##########
@@ -291,6 +295,8 @@ public List<PropertyDescriptor>
getSupportedPropertyDescriptors() {
descriptors.add(BUCKET);
descriptors.add(KEY);
descriptors.add(CONTENT_TYPE);
+ descriptors.add(RESOURCE_TRANSFER_SOURCE);
+ descriptors.add(FILE_RESOURCE_SERVICE);
descriptors.add(CRC32C);
descriptors.add(ACL);
Review Comment:
I would move the new properties up, before `CONTENT_TYPE`. In that way, the
properties would be "grouped" like:
- target (Bucket, Key)
- source
- metadata (Content Type, CRC, etc)
```suggestion
descriptors.add(BUCKET);
descriptors.add(KEY);
descriptors.add(RESOURCE_TRANSFER_SOURCE);
descriptors.add(FILE_RESOURCE_SERVICE);
descriptors.add(CONTENT_TYPE);
descriptors.add(CRC32C);
descriptors.add(ACL);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
