rfellows commented on code in PR #8305:
URL: https://github.com/apache/nifi/pull/8305#discussion_r1469948325
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/service/property-table-helper.service.ts:
##########
@@ -153,6 +180,20 @@ export class PropertyTableHelperService {
.getPropertyDescriptor(id,
descriptor.name, false)
.pipe(
take(1),
+ tap({
+ error: (errorResponse:
HttpErrorResponse) => {
+ // we've errored
getting the descriptor but since the service
+ // was already
created, we should close the create service dialog
+ // so multiple service
instances are not inadvertently created
+
createServiceDialogReference.close();
+
+ this.store.dispatch(
+ snackBarError({
+ error:
`Service created but until to reload Property Descriptor:
${errorResponse.error}`
Review Comment:
I'm a bit confused by this wording. Can we clarify it a bit more?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
