[ 
https://issues.apache.org/jira/browse/NIFI-2585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15765671#comment-15765671
 ] 

ASF GitHub Bot commented on NIFI-2585:
--------------------------------------

Github user ijokarumawak commented on the issue:

    https://github.com/apache/nifi/pull/1342
  
    @bbende Thanks for the comment. I reconsidered about s2s.address property, 
and by focusing only on the downstream flow, I think it probably doesn't matter 
whether the flow file came into the flow either by pulling or receiving it.
    
    If one needs to distinguish the direction in downstream flow, they can do 
so by adding UpdateAttribute to add whatever context they need. I think it's 
better to keep the number of attributes that NiFi framework create 
automatically at minimum. Removing feature from framework may be harder than 
adding it.
    
    So, I will keep the attribute names as they are now. Will update the PR 
with additional unit tests later. Thanks!


> Add attributes to track where a flow file came from when receiving over 
> site-to-site
> ------------------------------------------------------------------------------------
>
>                 Key: NIFI-2585
>                 URL: https://issues.apache.org/jira/browse/NIFI-2585
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Bryan Bende
>            Assignee: Randy Gelhausen
>            Priority: Minor
>
> With MiNiFi starting be used to send data to a central NiFi, it would be 
> helpful if information about the sending host and port was added to each flow 
> file received over site-to-site. Currently this information is available and 
> used to generate the transit URI in the RECEIVE event, but this information 
> isn't available to downstream processors that might want to make routing 
> decisions.
> For reference:
> https://github.com/apache/nifi/blob/e23b2356172e128086585fe2c425523c3628d0e7/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-site-to-site/src/main/java/org/apache/nifi/remote/protocol/AbstractFlowFileServerProtocol.java#L452
> A possible approach might be to add two attributes to each flow file, 
> something like "remote.host" and "remote.address" where remote.host has only 
> the sending hostname, and remote.address has the sending host and port.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to