[
https://issues.apache.org/jira/browse/NIFI-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15767214#comment-15767214
]
ASF GitHub Bot commented on NIFI-3236:
--------------------------------------
GitHub user brosander reopened a pull request:
https://github.com/apache/nifi/pull/1347
NIFI-3236 - SplitJson performance improvements
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [X] - N/A - Functionality already covered by tests - Have you written or
updated unit tests to verify your changes?
- [X] - N/A - If adding new dependencies to the code, are these
dependencies licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [X] - N/A - If applicable, have you updated the LICENSE file, including
the main LICENSE file under nifi-assembly?
- [X] - N/A - If applicable, have you updated the NOTICE file, including
the main NOTICE file found under nifi-assembly?
- [X] - N/A - If adding new Properties, have you added .displayName in
addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [X] - N/A - Have you ensured that format looks appropriate for the output
in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/brosander/nifi NIFI-3236
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1347.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1347
----
commit 57ec47fa2de2f052aa23761cc62ef5fdbfa43394
Author: Bryan Rosander <[email protected]>
Date: 2016-12-20T21:39:22Z
NIFI-3236 - SplitJson performance improvements
----
> SplitJson performance improvements
> ----------------------------------
>
> Key: NIFI-3236
> URL: https://issues.apache.org/jira/browse/NIFI-3236
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Bryan Rosander
> Assignee: Bryan Rosander
> Priority: Minor
> Attachments: after.png, before.png
>
>
> SplitJson does a lot of work in every onTrigger() that it doesn't need to.
> This includes putting each attribute separately as well as looping over the
> output segments twice.
> It also fetches a property in onTrigger() that could be gotten in an
> @OnScheduled method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
