Re: [PR] [NIFI-12698] dark mode, [NIFI-12687] status history axis label fix [nifi]

[via GitHub]

scottyaslan commented on PR #8320:
URL: https://github.com/apache/nifi/pull/8320#issuecomment-1921775225

   > Overall, this is AWESOME! Thanks @scottyaslan. I did find a handful of 
things that could be addressed, but I'm happy if we want to include those in 
some follow-up commit for dark-mode. Let me know what you think...
   > 
   > 1. The skeleton loaders might need some love. They flash pretty quick, but 
if you force them to stay on they are really bright.
   > 
   > <img alt="Screenshot 2024-02-01 at 8 57 52 AM" width="800" 
src="https://private-user-images.githubusercontent.com/713866/301528553-da082f80-63e8-40b0-91c6-00c85ae0d796.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDY4MDIzMzcsIm5iZiI6MTcwNjgwMjAzNywicGF0aCI6Ii83MTM4NjYvMzAxNTI4NTUzLWRhMDgyZjgwLTYzZTgtNDBiMC05MWM2LTAwYzg1YWUwZDc5Ni5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwMjAxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDIwMVQxNTQwMzdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1kYTU1ZDQ2MzUwZGZhMTMxN2U0ZWM2MzA4ZDc5MzY3MTk3M2VjZWRkMGEwN2Q5NTI4ZThhNWRlZjBlMWE5MmE5JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.Tz7YXUlEpQV88Oe3nHU7cFOi3c5zVCRrVNs3bOpipYg";>
   
   https://issues.apache.org/jira/browse/NIFI-12720
   
   > 2. When a disabled button is directly on a really dark background it is 
hard to read. In most cases, we only have them on a slightly lighter background 
(dialogs) and it looks fine.
   > 
   > <img alt="Screenshot 2024-02-01 at 9 04 35 AM" width="270" 
src="https://private-user-images.githubusercontent.com/713866/301530373-1422ecd1-65ff-4018-8b86-e05cb15578de.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDY4MDIzMzcsIm5iZiI6MTcwNjgwMjAzNywicGF0aCI6Ii83MTM4NjYvMzAxNTMwMzczLTE0MjJlY2QxLTY1ZmYtNDAxOC04Yjg2LWUwNWNiMTU1NzhkZS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwMjAxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDIwMVQxNTQwMzdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1jOGE2M2YzMzdhYmNmZjI5ZGU4NzY3NzUxYmZhMDY3ZjRiYzRhN2YyNWYzZjYwNzAxNTA2MzhkYmRkNmI4NjcwJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.l1ITR1LqfAcbsmmIPapv1o2Ne8Lk4nx1Jut_Tkudokg";>
 vs. <img alt="Screenshot 2024-02-01 at 9 07 24 AM" width="270" 
src="https://private-user-images.githubusercon
 
tent.com/713866/301530877-360e7e1e-c03f-432a-bbd6-201fec4fad5d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDY4MDIzMzcsIm5iZiI6MTcwNjgwMjAzNywicGF0aCI6Ii83MTM4NjYvMzAxNTMwODc3LTM2MGU3ZTFlLWMwM2YtNDMyYS1iYmQ2LTIwMWZlYzRmYWQ1ZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwMjAxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDIwMVQxNTQwMzdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02ZTBjNmE1NzkwMmUyOTkwMzRlZDMxMWNiN2I1MmVkZDBkMjg3ZTgzMjNmZWE3ZjhiYTc4NTI2NzFmMzBkNTIzJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.b6WZaVNSAqI58lgt8j3UCSRTs6YS0_OSB--nRvg3tzc">
   
   https://issues.apache.org/jira/browse/NIFI-12721
   
   > 3. The tables are a bit hard on my eyes. Its not terrible, but it the text 
seems too bright, especially when bold. The outline is also bright. Icons in a 
selected row are hard to look at:
   > 
   > <img alt="Screenshot 2024-02-01 at 9 10 23 AM" width="500" 
src="https://private-user-images.githubusercontent.com/713866/301532459-5b7a4d48-59a1-4726-b94e-11c6d04b8b72.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDY4MDIzMzcsIm5iZiI6MTcwNjgwMjAzNywicGF0aCI6Ii83MTM4NjYvMzAxNTMyNDU5LTViN2E0ZDQ4LTU5YTEtNDcyNi1iOTRlLTExYzZkMDRiOGI3Mi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwMjAxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDIwMVQxNTQwMzdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05ZmQ4Y2E0YjFmMzQxZThjNTczMWZmOWE1MWQxY2VlMzE2ZTdjMmE1YTU2NTJjMzRiYjQzNWJkODY4NDNjNTZkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.FSYlzBZe3e7zLM_3gIpPWM_12Qfj-ABVB2eHx-bPZoE";>
   
   https://issues.apache.org/jira/browse/NIFI-12722
   
   > 4. The error (red) color is very bright and jumps off the screen a bit too 
much IMO.
   > 
   > <img alt="Screenshot 2024-02-01 at 9 15 42 AM" width="800" 
src="https://private-user-images.githubusercontent.com/713866/301533319-f0b30b73-6720-42d5-8d1d-4cbf2c0bf2ad.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDY4MDIzMzcsIm5iZiI6MTcwNjgwMjAzNywicGF0aCI6Ii83MTM4NjYvMzAxNTMzMzE5LWYwYjMwYjczLTY3MjAtNDJkNS04ZDFkLTRjYmYyYzBiZjJhZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwMjAxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDIwMVQxNTQwMzdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02MjVhZjEwNDMzYzM1ZWY4ODc0NWYzMTc0MTk0ODliNDE5MTY1MTExZWFjOTBmZTUxN2FkYTYxNTY5ZjUxOGI1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.UzBocogFPlRNSbTjlxLtIFzsNfeWPWEgq_LNKJRQ7y8";>
   
   I pushed a fix for this. Let me know what you think.
   
   > 5. The text color in the Provenance graph is hard to read
   > 
   > <img alt="Screenshot 2024-02-01 at 9 48 48 AM" width="258" 
src="https://private-user-images.githubusercontent.com/713866/301543574-e383275a-f12f-4b42-a5e3-c162983cbfe9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDY4MDIzMzcsIm5iZiI6MTcwNjgwMjAzNywicGF0aCI6Ii83MTM4NjYvMzAxNTQzNTc0LWUzODMyNzVhLWYxMmYtNGI0Mi1hNWUzLWMxNjI5ODNjYmZlOS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwMjAxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDIwMVQxNTQwMzdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00YTZjZjg5MWZiYmQyMDc1NDM0Y2E5NWZlYTBiMjFiMGJhMTcwMDc1NmI2MGQxMTIyMGZjZjJhMjM0Mjg3YWQxJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.VqCrs-nBDdAF43UtKR_e0EzaNbAJZXFh67v86_gljOY";>
   
   I pushed a fix for this too.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org