Lehel44 commented on PR #8319: URL: https://github.com/apache/nifi/pull/8319#issuecomment-1933357560
Thanks @markap14 for making this. I went through the code and unit tests, as well did some manual testing and verifying property migrations. The changes made to the JsonWriter appear to function as intended. One concern is that while the changes to the JsonWriter fixed the scientific notation problem, the RecordReader still uses scientific notation by default. This mismatch could cause unexpected issues when using both components together. In my tests, I noticed that the `WriteJsonResult::writeRecord` received records in scientific notation, which might not be what users expect. To avoid confusion and ensure consistency, it would be wise to update the RecordReader to match the changes made to the JsonWriter. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
