mcgilman commented on code in PR #8376:
URL: https://github.com/apache/nifi/pull/8376#discussion_r1484505949
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/state/flow/flow.effects.ts:
##########
@@ -222,6 +224,17 @@ export class FlowEffects {
}),
catchError((error) =>
of(FlowActions.flowApiError({ error: error.error })))
);
+ case ComponentType.RemoteProcessGroup:
+ return
from(this.flowService.getParameterContexts()).pipe(
Review Comment:
The create Remote Process Group dialog does not require the Parameter
Contexts. This `case` should be able to simply return the action for opening
the dialog. Kind of like the cases for Processors or Ports.
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/items/remote-process-group/create-remote-process-group/create-remote-process-group.component.html:
##########
@@ -0,0 +1,115 @@
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+
+<h2 mat-dialog-title>Create Remote Process Group</h2>
+<form class="create-remote-process-group-form"
[formGroup]="createRemoteProcessGroupForm">
+ <error-banner></error-banner>
+ <mat-dialog-content>
+ <div class="tab-content py-4 flex gap-x-4">
+ <div class="w-full">
+ <mat-form-field>
+ <mat-label>URLs</mat-label>
+ <input matInput formControlName="urls" type="text"
placeholder="https://remotehost:8443/nifi"; />
+ </mat-form-field>
+ </div>
+ </div>
+ <div class="flex gap-x-4">
+ <div class="w-full">
+ <mat-form-field>
+ <mat-label>Transport Protocol</mat-label>
+ <mat-select formControlName="transportProtocol">
+ <mat-option
+ value="RAW"
+ nifiTooltip
+ [tooltipComponentType]="TextTip"
+ [tooltipInputData]="getOptionTipData('RAW')"
+ [delayClose]="false">
+ RAW
+ </mat-option>
+ <mat-option
+ value="HTTP"
+ nifiTooltip
+ [tooltipComponentType]="TextTip"
+ [tooltipInputData]="getOptionTipData('HTTP')"
+ [delayClose]="false">
+ HTTP
+ </mat-option>
+ </mat-select>
+ </mat-form-field>
+ </div>
+ <div class="w-full">
+ <mat-form-field>
+ <mat-label>Local Network Interface</mat-label>
+ <input matInput formControlName="localNetworkInterface"
type="text" />
+ </mat-form-field>
+ </div>
+ </div>
+ <div class="flex gap-x-4">
+ <div class="w-full">
+ <mat-form-field>
+ <mat-label>HTTP Proxy Server Hostname</mat-label>
+ <input matInput formControlName="httpProxyServerHostname"
type="text" />
+ </mat-form-field>
+ </div>
+ <div class="w-full">
+ <mat-form-field>
+ <mat-label>HTTP Proxy Server Port</mat-label>
+ <input matInput formControlName="httpProxyServerPort"
type="text" />
+ </mat-form-field>
+ </div>
+ </div>
+ <div class="flex gap-x-4">
+ <div class="w-full">
+ <mat-form-field>
+ <mat-label>HTTP Proxy User</mat-label>
+ <input matInput formControlName="httpProxyUser"
type="text" />
+ </mat-form-field>
+ </div>
+ <div class="w-full">
+ <mat-form-field>
+ <mat-label>HTTP Proxy Password</mat-label>
+ <input matInput formControlName="httpProxyPassword"
type="text" />
+ </mat-form-field>
+ </div>
+ </div>
+ <div class="flex gap-x-4">
+ <div class="w-full">
+ <mat-form-field>
+ <mat-label>Communications Timeout</mat-label>
+ <input matInput formControlName="communicationsTimeout"
type="text" />
+ </mat-form-field>
+ </div>
+ <div class="w-full">
+ <mat-form-field>
+ <mat-label>Yield Duration</mat-label>
+ <input matInput formControlName="yieldDuration"
type="text" />
+ </mat-form-field>
+ </div>
+ </div>
+ </mat-dialog-content>
+ <mat-dialog-actions align="end" *ngIf="{ value: (saving$ | async)! } as
saving">
+ <button color="primary" mat-stroked-button
mat-dialog-close>Cancel</button>
+ <button
+ [disabled]="!createRemoteProcessGroupForm.dirty ||
createRemoteProcessGroupForm.invalid || saving.value"
+ type="button"
+ color="primary"
+ (click)="createRemoteProcessGroup()"
+ mat-raised-button>
+ <span *nifiSpinner="saving.value">Add</span>
+ </button>
+ </mat-dialog-actions>
Review Comment:
Can these buttons be aligned to the bottom? In this case, this appears to be
happening because the dialog content does not fill the space of the panel class
that was chosen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
