mcgilman commented on code in PR #8416:
URL: https://github.com/apache/nifi/pull/8416#discussion_r1492471475
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/controller-service/controller-service-table/controller-service-table.component.html:
##########
@@ -31,13 +31,11 @@
<td mat-cell *matCellDef="let item">
@if (canRead(item)) {
<div class="flex items-center gap-x-3">
- <div class="pointer fa fa-book"
title="Usage"></div>
- <!--
- nifiTooltip dynamically inserts the tooltip component
- into the dom. the dom placement caused shifting of icons
- because of the gap between items. simple solution is to
- just wrap the target.
- -->
+ <div
+ class="pointer fa fa-book"
+ (click)="viewDocumentationClicked(item,
$event)"
+ title="View Documentation"></div>
Review Comment:
We could look at other options when considering our strategy for tooltips
throughout. We still need to address all the info icons. But thus far, all
buttons and icons in table listings have used `title`. Here I only updated the
value.
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/settings/ui/parameter-providers/parameter-providers-table/parameter-providers-table.component.html:
##########
@@ -31,25 +31,29 @@
<ng-container matColumnDef="moreDetails">
<th mat-header-cell *matHeaderCellDef></th>
<td mat-cell *matCellDef="let item">
- <div class="flex items-center gap-x-3">
- <!-- TODO: open details -->
- <div class="pointer fa fa-info-circle"
title="View details"></div>
+ @if (canRead(item)) {
+ <div class="flex items-center gap-x-3">
+ <!-- TODO: open details -->
+ <div class="pointer fa fa-info-circle"
title="View details"></div>
- <!-- TODO: open documentation -->
- <div class="pointer fa fa-book" title="View
Documentation"></div>
+ <div
+ class="pointer fa fa-book"
+
(click)="viewDocumentationClicked(item, $event)"
+ title="View Documentation"></div>
Review Comment:
Same comment as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
