dan-s1 commented on code in PR #8417:
URL: https://github.com/apache/nifi/pull/8417#discussion_r1492547462
##########
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/EncodeContent.java:
##########
@@ -112,9 +153,14 @@ public void onTrigger(final ProcessContext context, final
ProcessSession session
return;
}
- final boolean encode =
context.getProperty(MODE).getValue().equalsIgnoreCase(ENCODE_MODE);
+ final boolean encode =
context.getProperty(MODE).getValue().equals(EncodingMode.ENCODE.getValue());
final String encoding = context.getProperty(ENCODING).getValue();
Review Comment:
```suggestion
final EncodingType encoding =
EncodingType.valueOf(context.getProperty(ENCODING).getValue());
```
##########
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/EncodeContent.java:
##########
@@ -129,31 +175,35 @@ public void onTrigger(final ProcessContext context, final
ProcessSession session
}
}
- private static StreamCallback getStreamCallback(final boolean encode,
final String encoding) {
- if (encode) {
- if (encoding.equalsIgnoreCase(BASE64_ENCODING)) {
- return new EncodeBase64();
- } else if (encoding.equalsIgnoreCase(BASE32_ENCODING)) {
- return new EncodeBase32();
- } else {
- return new EncodeHex();
- }
- } else {
- if (encoding.equalsIgnoreCase(BASE64_ENCODING)) {
- return new DecodeBase64();
- } else if (encoding.equalsIgnoreCase(BASE32_ENCODING)) {
- return new DecodeBase32();
- } else {
- return new DecodeHex();
- }
+ private static StreamCallback getStreamCallback(final Boolean encode,
final String encoding,
+ final int lineLength, final String lineSeparator) {
+ switch(encoding) {
+ case "BASE64_ENCODING":
+ return encode ? new EncodeBase64(lineLength, lineSeparator) :
new DecodeBase64();
+ case "BASE32_ENCODING":
+ return encode ? new EncodeBase32(lineLength, lineSeparator) :
new DecodeBase32();
Review Comment:
```suggestion
private static StreamCallback getStreamCallback(final Boolean encode,
final EncodingType encoding,
final int lineLength, final String lineSeparator) {
switch(encoding) {
case BASE64_ENCODING:
return encode ? new EncodeBase64(lineLength, lineSeparator)
: new DecodeBase64();
case BASE32_ENCODING:
return encode ? new EncodeBase32(lineLength, lineSeparator)
: new DecodeBase32();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
