rfellows commented on code in PR #8431:
URL: https://github.com/apache/nifi/pull/8431#discussion_r1496514997
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/header/flow-status/flow-status.component.ts:
##########
@@ -55,8 +56,8 @@ export class FlowStatus {
getClusterStyle(): string {
if (
- !this.clusterSummary.connectedToCluster ||
- this.clusterSummary.connectedNodeCount !=
this.clusterSummary.totalNodeCount
+ this.clusterSummary?.connectedToCluster === false ||
+ this.clusterSummary?.connectedNodeCount !=
this.clusterSummary?.totalNodeCount
Review Comment:
It looks like the icon used in this scenario isn't colorized as it is in
original NiFi. We don't seem to have a `warning` style defined to make it our
warning/error red.
<img width="87" alt="Screenshot 2024-02-20 at 4 10 35 PM"
src="https://github.com/apache/nifi/assets/713866/627acc3b-03d5-49a2-9814-2befa1b1255a";>
vs.
<img width="72" alt="Screenshot 2024-02-20 at 4 11 06 PM"
src="https://github.com/apache/nifi/assets/713866/8170bfde-827c-45c5-8366-ed6039f65e26";>
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/provenance/state/provenance-event-listing/provenance-event-listing.effects.ts:
##########
@@ -237,9 +254,24 @@ export class ProvenanceEventListingEffects {
this.store.select(selectTimeOffset),
this.store.select(selectProvenanceOptions),
this.store.select(selectProvenanceRequest),
- this.store.select(selectAbout).pipe(isDefinedAndNotNull())
+ this.store.select(selectAbout).pipe(isDefinedAndNotNull()),
+
this.store.select(selectClusterSummary).pipe(isDefinedAndNotNull())
]),
- tap(([, timeOffset, options, currentRequest, about]) => {
+ tap(([, timeOffset, options, currentRequest, about,
clusterSummary]) => {
+ let clusterNodes$: Observable<NodeSearchResult[]>;
+ if (clusterSummary.connectedToCluster) {
+ clusterNodes$ =
this.clusterService.searchCluster().pipe(
+ tap({
+ error: (errorResponse: HttpErrorResponse) => {
+
this.store.dispatch(ErrorActions.snackBarError({ error: errorResponse.error }));
+ }
+ }),
Review Comment:
Handling the error in the `tap` here results in a behavior where the error
response is still available to the subscribing consumer and not handled. In
this case, that is `provenance-search-dialog.component.ts:61`. This fails, the
dialog opens and there are no nodes to select as search criteria.
We probably should not even open the dialog if this query fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
