dan-s1 commented on code in PR #8441: URL: https://github.com/apache/nifi/pull/8441#discussion_r1497954594
########## nifi-python-extensions/nifi-text-embeddings-module/src/main/python/vectorstores/OpenSearchVectorUtils.py: ########## @@ -0,0 +1,149 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +from nifiapi.properties import PropertyDescriptor, StandardValidators, ExpressionLanguageScope, PropertyDependency +from EmbeddingUtils import OPENAI, HUGGING_FACE, EMBEDDING_MODEL + +HUGGING_FACE_API_KEY = PropertyDescriptor( + name="HuggingFace API Key", + description="The API Key for interacting with HuggingFace", + required=True, + sensitive=True, + validators=[StandardValidators.NON_EMPTY_VALIDATOR], + dependencies=[PropertyDependency(EMBEDDING_MODEL, HUGGING_FACE)] +) +HUGGING_FACE_MODEL = PropertyDescriptor( + name="HuggingFace Model", + description="The name of the HuggingFace model to use", + default_value="sentence-transformers/all-MiniLM-L6-v2", + required=True, + validators=[StandardValidators.NON_EMPTY_VALIDATOR], + dependencies=[PropertyDependency(EMBEDDING_MODEL, HUGGING_FACE)] +) +OPENAI_API_KEY = PropertyDescriptor( + name="OpenAI API Key", + description="The API Key for OpenAI in order to create embeddings", + required=True, + sensitive=True, + validators=[StandardValidators.NON_EMPTY_VALIDATOR], + dependencies=[PropertyDependency(EMBEDDING_MODEL, OPENAI)] +) +OPENAI_API_MODEL = PropertyDescriptor( + name="OpenAI Model", + description="The API Key for OpenAI in order to create embeddings", + default_value="text-embedding-ada-002", + required=True, + validators=[StandardValidators.NON_EMPTY_VALIDATOR], + dependencies=[PropertyDependency(EMBEDDING_MODEL, OPENAI)] +) +HTTP_HOST = PropertyDescriptor( + name="HTTP Host", + description="URL where OpenSearch is hosted.", + default_value="http://localhost:9200";, + required=True, + validators=[StandardValidators.NON_EMPTY_VALIDATOR] Review Comment: I am not sure this is possible or not but the Java side of `StandardValidators` has `URL_VALIDATOR` and `URI_VALIDATOR` which would make more sense here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
