[
https://issues.apache.org/jira/browse/NIFI-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823356#comment-17823356
]
ASF subversion and git services commented on NIFI-12645:
--------------------------------------------------------
Commit 7f2f5e77f65af1d688330092b4df9747f68ade50 in nifi's branch
refs/heads/support/nifi-1.x from Jim Steinebrey
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=7f2f5e77f6 ]
NIFI-12645 Fix to correctly invoke onStopped method of scripted processor
Signed-off-by: Matt Burgess <[email protected]>
> InvokeScriptedProcessor: The onStopped method is never called
> -------------------------------------------------------------
>
> Key: NIFI-12645
> URL: https://issues.apache.org/jira/browse/NIFI-12645
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Environment: All operatiing system
> Reporter: Antonio Pezzuto
> Assignee: Jim Steinebrey
> Priority: Major
> Labels: easyfix
> Attachments: Test_Script_Body_InvokeScriptedProcessor.json,
> image-2024-01-19-12-40-24-453.png, image-2024-01-19-12-41-15-173.png,
> image-2024-01-19-12-44-08-030.png, image-2024-01-19-12-44-39-464.png
>
> Original Estimate: 24h
> Time Spent: 10m
> Remaining Estimate: 23h 50m
>
> Processor: *InvokeScriptedProcessor*
> Script Engine : groovy
> The _InvokeScriptedProcessor_ processor was used to create a custom processor
> in groovy.
> The groovy custom processor exposes the *onStopped* method
>
> {code:java}
> public void onStopped(ProcessContext context) throws Exception {
> System.out.println("Stop")
> restServer?.shutDown()
> }{code}
>
> When the _InvokeScriptedProcessor_ is stopped the groovy processor's
> *onStopped* method is not invoked.
> I ran the InvokeScriptedProcessor processor in remote debug and the cause
> seems to be due to a bug in the management of the scriptNeedsReload variable.
> The groovy processor's onStopped method executes only if the
> scriptNeedsReload instance variable equals false
> !image-2024-01-19-12-41-15-173.png!
> According to my analysis _scriptNeedsReload_ is always set to true due to an
> error in the *reloadScript* method.
> Currently the *reloadScript* method returns true if the script body is empty
> or if there are validation errors, it returns false if there are no
> validation errors.
> The *reloadScript* method should return true if there are no validation
> errors and return false if the script body is empty or if there are
> validation errors.
> !image-2024-01-19-12-44-08-030.png!
> !image-2024-01-19-12-44-39-464.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
