Github user jackowaya commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1355#discussion_r93767588
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteStreamCommand.java
---
@@ -186,7 +195,15 @@ public ValidationResult validate(String subject,
String input, ValidationContext
.addValidator(StandardValidators.createDirectoryExistsValidator(true, true))
.required(false)
.build();
-
+ static final PropertyDescriptor REDIRECT_ERROR = new
PropertyDescriptor.Builder()
+ .name("Redirect Error Stream")
+ .description("where shoud the error stream from external
process get redirected"
+ + "\n1) log - outputs to the nifi logger"
+ + "\n2) output stream - redirects to the output stream
relation"
+ + "\n3) error stream - redirects to the error stream
relation")
+ .allowableValues("log", "output stream","error stream")
--- End diff --
It would be better to hold these strings in static final variables so they
can be reused later without fear of mistyping.
Also spacing looks off here. You should run autoformat again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
