exceptionfactory commented on PR #8502: URL: https://github.com/apache/nifi/pull/8502#issuecomment-2000090444
> > It may be helpful to scope down the number of timestamps in the provideTimestamps method to focus on differences. > > @exceptionfactory Okay. I scoped it down to 2 formats: `ISO_LOCAL_DATE_TIME` and `ISO_OFFSET_DATE_TIME` and I limited the offset to `+00:00`. Because there were parsing failures previously, I think it's indicative of some race conditions we're not covering, which is out of scope for this change. Given that best practice is ISO format and UTC+0 for most db's anyway, I think we should be fine. Thanks for making the updates, unfortunately the tests are still failing: ``` Error: org.apache.nifi.serialization.record.TestMapRecord.testGettingLocalDateAndOffsetDateTime(Object, String, long, long)[1] -- Time elapsed: 0.031 s <<< FAILURE! org.opentest4j.AssertionFailedError: expected: <1641040496789> but was: <1641072896789> ``` The problem is not a race condition, but the fact of the different GitHub Runners have different local time zones. Converting between UTC and local time changes the expected epoch values, so the expectations need to be written such that they work across all time zones. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
