scottyaslan commented on code in PR #8535:
URL: https://github.com/apache/nifi/pull/8535#discussion_r1538266243
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-configuration-history/state/flow-configuration-history-listing/flow-configuration-history-listing.effects.ts:
##########
@@ -95,7 +96,7 @@ export class FlowConfigurationHistoryListingEffects {
ofType(HistoryActions.openPurgeHistoryDialog),
tap(() => {
const dialogReference = this.dialog.open(PurgeHistory, {
- panelClass: 'medium-short-dialog'
+ ...DIALOG_SIZES.LARGE
Review Comment:
This one was a bit special as it was the only 'medium-short-dialog'. I tried
to go with the MEDIUM dialog here but Angular Material puts a `width: 180px` on
the `.mat-mdc-form-field-infix` class. In a MEDIUM dialog like this where these
two input fields are next to each other in the UX then the input field takes up
236px. Two inputs plus padding in between and on either side would be too wide
to fit into a 460px wide MEDIUM dialog:
<img width="1726" alt="Screenshot 2024-03-25 at 5 28 21 PM"
src="https://github.com/apache/nifi/assets/6797571/4251e3a7-63c1-4b01-b733-a5d8046ec683";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
