turcsanyip commented on code in PR #8544:
URL: https://github.com/apache/nifi/pull/8544#discussion_r1541225410
##########
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/PutHDFS.java:
##########
@@ -160,6 +170,14 @@ public class PutHDFS extends AbstractHadoopProcessor {
.allowableValues(WRITE_AND_RENAME_AV, SIMPLE_WRITE_AV)
.build();
+ public static final PropertyDescriptor APPEND_MODE = new
PropertyDescriptor.Builder()
+ .name("Append Mode")
+ .description("Defines the append strategy to use when the Conflict
Resolution Strategy is set to 'append'.")
+ .allowableValues(DEFAULT_APPEND_MODE, AVRO_APPEND_MODE)
+ .defaultValue(DEFAULT_APPEND_MODE)
+ .required(true)
+ .build();
Review Comment:
`Append Mode` property should depend on `Conflict Resolution Strategy` and
should only be shown if the strategy is `append`.
I also suggest placing the new property just below `Conflict Resolution
Strategy`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
