szaszm commented on code in PR #1748:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1748#discussion_r1541285411
##########
extensions/libarchive/BinFiles.cpp:
##########
@@ -223,11 +223,14 @@ bool BinFiles::resurrectFlowFiles(core::ProcessSession
&session) {
return had_failure;
}
-void BinFiles::assumeOwnershipOfNextBatch(core::ProcessSession &session) {
+bool BinFiles::assumeOwnershipOfNextBatch(core::ProcessSession &session) {
for (size_t i = 0; i < batchSize_; ++i) {
auto flow = session.get();
if (flow == nullptr) {
+ if (i == 0) {
+ return false;
+ }
Review Comment:
More comments would be nice around the appreciated. What is special about
getting a nullptr at index 0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
