Re: [PR] NIFI-12972 - Only show selected relationships in read-only connection details [nifi]

[via GitHub]

pvillard31 commented on code in PR #8582:
URL: https://github.com/apache/nifi/pull/8582#discussion_r1546026094


##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/nf-connection-details.js:
##########
@@ -496,10 +496,10 @@
                         var availableRelationships = 
connection.availableRelationships;
                         var selectedRelationships = 
connection.selectedRelationships;
 
-                        // show the available relationship if applicable
+                        // show the selected relationships if applicable
                         if 
(nfCommon.isDefinedAndNotNull(availableRelationships) || 
nfCommon.isDefinedAndNotNull(selectedRelationships)) {
-                            // populate the available connections
-                            $.each(availableRelationships, function (i, name) {
+                            // populate the selected connections
+                            $.each(selectedRelationships, function (i, name) {
                                 createRelationshipOption(name);
                             });

Review Comment:
   Thanks Matt for catching this. I just pushed a new commit with the suggested 
changes.
   
   ![Screenshot 2024-04-01 at 09 50 
11](https://github.com/apache/nifi/assets/11541012/6486eaec-68f9-4dcd-94f8-951d8d3b56de)
   ![Screenshot 2024-04-01 at 09 50 
20](https://github.com/apache/nifi/assets/11541012/40de7704-7aea-4b43-95e9-338d1fcca485)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org