rfellows commented on code in PR #8596:
URL: https://github.com/apache/nifi/pull/8596#discussion_r1551618697
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/service/canvas-context-menu.service.ts:
##########
@@ -139,14 +175,18 @@ export class CanvasContextMenu implements
ContextMenuDefinitionProvider {
isSeparator: true
},
{
- condition: (selection: any) => {
- // TODO - supportsStopFlowVersioning
- return false;
+ condition: (selection: d3.Selection<any, any, any, any>) => {
+ return
this.canvasUtils.supportsStopFlowVersioning(selection);
},
clazz: 'fa',
text: 'Stop version control',
- action: () => {
- // TODO - stopVersionControl
+ action: (selection: d3.Selection<any, any, any, any>) => {
+ const selectionData = selection.datum();
+ const request: StopVersionControlRequest = {
+ revision: selectionData.revision,
+ processGroupId: selectionData.id
+ };
+ this.store.dispatch(stopVersionControlRequest({ request
}));
Review Comment:
I realized after I started working on the next few actions for versioning
that this doesn't support stopping process group if no selection is made
(meaning it is the canvas pg). I have addressed this in my upcoming PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
