greyp9 commented on code in PR #8463: URL: https://github.com/apache/nifi/pull/8463#discussion_r1556223354
########## nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/kafka/processors/ConsumeKafka.java: ########## @@ -0,0 +1,464 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.kafka.processors; + +import org.apache.nifi.annotation.behavior.InputRequirement; +import org.apache.nifi.annotation.documentation.Tags; +import org.apache.nifi.annotation.lifecycle.OnScheduled; +import org.apache.nifi.annotation.lifecycle.OnStopped; +import org.apache.nifi.components.AllowableValue; +import org.apache.nifi.components.ConfigVerificationResult; +import org.apache.nifi.components.PropertyDescriptor; +import org.apache.nifi.components.PropertyValue; +import org.apache.nifi.components.Validator; +import org.apache.nifi.expression.ExpressionLanguageScope; +import org.apache.nifi.kafka.processors.common.KafkaUtils; +import org.apache.nifi.kafka.processors.consumer.OffsetTracker; +import org.apache.nifi.kafka.processors.consumer.ProcessingStrategy; +import org.apache.nifi.kafka.processors.consumer.bundle.ByteRecordBundler; +import org.apache.nifi.kafka.processors.consumer.convert.FlowFileStreamKafkaMessageConverter; +import org.apache.nifi.kafka.processors.consumer.convert.KafkaMessageConverter; +import org.apache.nifi.kafka.processors.consumer.convert.RecordStreamKafkaMessageConverter; +import org.apache.nifi.kafka.processors.consumer.convert.WrapperRecordStreamKafkaMessageConverter; +import org.apache.nifi.kafka.service.api.KafkaConnectionService; +import org.apache.nifi.kafka.service.api.common.PartitionState; +import org.apache.nifi.kafka.service.api.consumer.AutoOffsetReset; +import org.apache.nifi.kafka.service.api.consumer.ConsumerConfiguration; +import org.apache.nifi.kafka.service.api.consumer.KafkaConsumerService; +import org.apache.nifi.kafka.service.api.consumer.PollingContext; +import org.apache.nifi.kafka.service.api.record.ByteRecord; +import org.apache.nifi.kafka.shared.attribute.KafkaFlowFileAttribute; +import org.apache.nifi.kafka.shared.property.KeyEncoding; +import org.apache.nifi.kafka.shared.property.KeyFormat; +import org.apache.nifi.kafka.shared.property.OutputStrategy; +import org.apache.nifi.logging.ComponentLog; +import org.apache.nifi.processor.AbstractProcessor; +import org.apache.nifi.processor.ProcessContext; +import org.apache.nifi.processor.ProcessSession; +import org.apache.nifi.processor.Relationship; +import org.apache.nifi.processor.VerifiableProcessor; +import org.apache.nifi.processor.exception.ProcessException; +import org.apache.nifi.processor.util.StandardValidators; +import org.apache.nifi.serialization.RecordReaderFactory; +import org.apache.nifi.serialization.RecordSetWriterFactory; +import org.apache.nifi.util.StringUtils; + +import java.nio.charset.Charset; +import java.nio.charset.StandardCharsets; +import java.time.Duration; +import java.util.ArrayList; +import java.util.Collection; +import java.util.Collections; +import java.util.Iterator; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.regex.Pattern; + +import static org.apache.nifi.expression.ExpressionLanguageScope.NONE; + +@InputRequirement(InputRequirement.Requirement.INPUT_FORBIDDEN) +@Tags({"kafka", "consumer", "record"}) +public class ConsumeKafka extends AbstractProcessor implements VerifiableProcessor { + + static final AllowableValue TOPIC_NAME = new AllowableValue("names", "names", "Topic is a full topic name or comma separated list of names"); + static final AllowableValue TOPIC_PATTERN = new AllowableValue("pattern", "pattern", "Topic is a regex using the Java Pattern syntax"); + + static final PropertyDescriptor CONNECTION_SERVICE = new PropertyDescriptor.Builder() + .name("Kafka Connection Service") + .displayName("Kafka Connection Service") + .description("Provides connections to Kafka Broker for publishing Kafka Records") + .identifiesControllerService(KafkaConnectionService.class) + .expressionLanguageSupported(NONE) + .required(true) + .build(); + + static final PropertyDescriptor GROUP_ID = new PropertyDescriptor.Builder() + .name("Group ID") Review Comment: I've extracted the property descriptors out of KafkaConnectionService3, PublishKafka, and ConsumeKafka. I've applied the following heuristic to map PD DisplayName to Name: (1) When a property can be directly mapped to an underlying Kafka property, use the Kafka property name (their naming convention seems to be "a.b.c". (2) Otherwise, use the existing NiFi display name. Here is that set, in a text file, along with a few links to the underlying Kafka config classes. If this aligns with the vision, I'll update with these changes. [08T.PropertyDescriptors.txt](https://github.com/apache/nifi/files/14909236/08T.PropertyDescriptors.txt) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
