szaszm commented on code in PR #1755:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1755#discussion_r1562992485
##########
minifi_main/CMakeLists.txt:
##########
@@ -74,12 +74,10 @@ if (WIN32)
target_compile_definitions(minifiexe PUBLIC SERVICE_NAME="Apache NiFi
MINiFi")
endif()
-if (NOT WIN32)
-add_custom_command(TARGET minifiexe POST_BUILD
- COMMAND cat ${CMAKE_BINARY_DIR}/all.log)
+if (WIN32)
+ add_custom_command(TARGET minifiexe POST_BUILD COMMAND ${CMAKE_COMMAND} -E
copy $<TARGET_FILE:minifiexe> ${CMAKE_BINARY_DIR}/minifi_main/)
else()
-#add_custom_command(TARGET minifiexe POST_BUILD
-# COMMAND type ${CMAKE_BINARY_DIR}/all.log)
+ add_custom_command(TARGET minifiexe POST_BUILD COMMAND cat
${CMAKE_BINARY_DIR}/all.log)
Review Comment:
I think this `cat` can go, the contents of that log file is bogus anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
