exceptionfactory commented on code in PR #8649:
URL: https://github.com/apache/nifi/pull/8649#discussion_r1567358326
##########
nifi-registry/nifi-registry-core/nifi-registry-web-ui/src/main/webapp/components/explorer/grid-list/registry/nf-registry-grid-list-viewer.html:
##########
@@ -121,6 +121,38 @@
</td-step>
</td-steps>
</div>
+ <div *ngIf="droplet.bundleType"
id="nifi-registry-explorer-grid-list-viewer-droplet-container-details-change-log">
+ <td-steps mode="vertical">
+ <td-step label="Version
{{snapshotMeta.version}}
({{nfRegistryService.getHumanReadableSize(snapshotMeta.contentSize)}}) -
{{snapshotMeta.timestamp | amTimeAgo}}" sublabel="by {{snapshotMeta.author}}"
+ *ngFor="let snapshotMeta of
droplet.snapshotMetadata; let i = index"
+ [active]="i === 0 ? true : false">
+ <div fxLayout="column"
fxLayoutAlign="space-between stretch">
+ <div fxLayout="row"
class="mat-body-3">
+ <p>
+ Build Information<br />
+
<b>NiFi API version</b>:
{{snapshotMeta.systemApiVersion}}<br />
+
<b>Build branch</b>:
{{snapshotMeta.buildInfo.buildBranch}}<br />
Review Comment:
Recommend capitalizing the second word in these lines:
```suggestion
<b>Build Branch</b>:
{{snapshotMeta.buildInfo.buildBranch}}<br />
```
##########
nifi-registry/nifi-registry-core/nifi-registry-web-ui/src/main/webapp/components/explorer/grid-list/registry/nf-registry-grid-list-viewer.html:
##########
@@ -121,6 +121,38 @@
</td-step>
</td-steps>
</div>
+ <div *ngIf="droplet.bundleType"
id="nifi-registry-explorer-grid-list-viewer-droplet-container-details-change-log">
+ <td-steps mode="vertical">
+ <td-step label="Version
{{snapshotMeta.version}}
({{nfRegistryService.getHumanReadableSize(snapshotMeta.contentSize)}}) -
{{snapshotMeta.timestamp | amTimeAgo}}" sublabel="by {{snapshotMeta.author}}"
+ *ngFor="let snapshotMeta of
droplet.snapshotMetadata; let i = index"
+ [active]="i === 0 ? true : false">
+ <div fxLayout="column"
fxLayoutAlign="space-between stretch">
+ <div fxLayout="row"
class="mat-body-3">
+ <p>
+ Build Information<br />
+
<b>NiFi API version</b>:
{{snapshotMeta.systemApiVersion}}<br />
Review Comment:
Using non-breaking spaces for formatting is not ideal, so I recommend using
styled `div` tags instead.
##########
nifi-registry/nifi-registry-core/nifi-registry-web-ui/src/main/webapp/components/explorer/grid-list/registry/nf-registry-grid-list-viewer.html:
##########
@@ -121,6 +121,38 @@
</td-step>
</td-steps>
</div>
+ <div *ngIf="droplet.bundleType"
id="nifi-registry-explorer-grid-list-viewer-droplet-container-details-change-log">
+ <td-steps mode="vertical">
+ <td-step label="Version
{{snapshotMeta.version}}
({{nfRegistryService.getHumanReadableSize(snapshotMeta.contentSize)}}) -
{{snapshotMeta.timestamp | amTimeAgo}}" sublabel="by {{snapshotMeta.author}}"
+ *ngFor="let snapshotMeta of
droplet.snapshotMetadata; let i = index"
+ [active]="i === 0 ? true : false">
+ <div fxLayout="column"
fxLayoutAlign="space-between stretch">
+ <div fxLayout="row"
class="mat-body-3">
+ <p>
+ Build Information<br />
+
<b>NiFi API version</b>:
{{snapshotMeta.systemApiVersion}}<br />
+
<b>Build branch</b>:
{{snapshotMeta.buildInfo.buildBranch}}<br />
+
<b>Build flags</b>:
{{snapshotMeta.buildInfo.buildFlags}}<br />
+
<b>Build revision</b>:
{{snapshotMeta.buildInfo.buildRevision}}<br />
+
<b>Build tag</b>:
{{snapshotMeta.buildInfo.buildTag}}<br />
+
<b>Build tool</b>:
{{snapshotMeta.buildInfo.buildTool}}<br />
+
<b>Built by</b>: {{snapshotMeta.buildInfo.builtBy}}<br
/>
+
<b>Built on</b>: {{(snapshotMeta.buildInfo.built/1000 |
amFromUnix) | amDateFormat:'MMM-DD-YYYY'}} at
{{(snapshotMeta.buildInfo.built/1000 | amFromUnix) | amDateFormat:'h:mm A'}}
Review Comment:
Is the `MMM-DD-YYYY` format common elsewhere in the application? I recommend
using the ISO 8601 format of `YYYY-MM-DD`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
