szaszm commented on code in PR #1762:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1762#discussion_r1575079441
##########
extensions/python/PYTHON.md:
##########
@@ -102,10 +102,12 @@ NON_BLANK = 5
PORT = 6
```
+The last parameter of addProperty is the controller service type. If the
property is a controller service, the controller service type should be
provided. It should be the non-qualified type name of the controller service.
Currently SSLContextService is the only controller service type supported.
+
```python
def onInitialize(processor):
processor.setSupportsDynamicProperties()
- processor.addProperty("property name","description","default value", True
/*required*/, False /*expression language supported*/, False /*sensitive*/, 1
/*property type code*/)
+ processor.addProperty("property name", "description", "default value", True
/*required*/, False /*expression language supported*/, False /*sensitive*/, 1
/*property type code*/, None /*controller service type name*/)
Review Comment:
These `/**/` style comments are not valid python. I'm assuming this comes
from the NiFi Python API. Otherwise I'd consider changing to keyword arguments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
