fgerlits commented on code in PR #1765:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1765#discussion_r1575778051


##########
docker/test/integration/cluster/containers/MinifiContainer.py:
##########
@@ -177,6 +178,8 @@ def deploy(self):
 
         if self.options.enable_sql:
             image = self.image_store.get_image('minifi-cpp-sql')
+        elif self.options.enable_example_minifi_python_processors:
+            image = 
self.image_store.get_image('minifi-cpp-with-example-python-processors')
         elif 
self.options.use_nifi_python_processors_with_system_python_packages_installed:
             image = 
self.image_store.get_image('minifi-cpp-nifi-python-system-python-packages')

Review Comment:
   Why do we only allow one of these at a time?  I would expect (both 
`enable_sql` and) `enable_example_minifi_python_processors` to be add-ons to 
the other images rather than stand-alone images themselves.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to