lordgamez commented on code in PR #1766:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1766#discussion_r1577839801
##########
bootstrap.sh:
##########
@@ -445,7 +445,8 @@ build_cmake_command(){
set_value=OFF
option_value="${!option}"
if { [[ "$option_value" = "${FALSE}" ]] && { [[ "$FOUND_VALUE" ==
"DISABLE"* ]] || [[ "$FOUND_VALUE" == *"OFF" ]]; }; } || \
- { [[ "$option_value" = "${TRUE}" ]] && [[ "$FOUND_VALUE" == "ENABLE"*
]]; }; then
+ { [[ "$option_value" = "${TRUE}" ]] && [[ "$FOUND_VALUE" == "ENABLE"*
]]; } ||
+ { [[ "$option_value" = "${TRUE}" ]] && [[ "$FOUND_VALUE" != "ENABLE"*
]] && [[ "$FOUND_VALUE" != "DISABLE"* ]]; }; then
Review Comment:
I think you are right, we went great lengths last time to remove any
"negative" options so we should not introduce options with _OFF anyways. I
removed the logic to handle `*"OFF"` options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
