rfellows commented on code in PR #8703:
URL: https://github.com/apache/nifi/pull/8703#discussion_r1581517901
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/state/system-diagnostics/system-diagnostics.effects.ts:
##########
@@ -49,13 +51,24 @@ export class SystemDiagnosticsEffects {
}
})
),
- catchError((error) =>
- of(
-
SystemDiagnosticsActions.systemDiagnosticsApiError({
- error: error.error
+ catchError((errorResponse: HttpErrorResponse) => {
+ if (request.source === 'cluster-listing') {
+ return of(
+ ErrorActions.snackBarError({
Review Comment:
After further consideration, this presents a potential issue with the
cluster listing and the system diagnostics dialog are both open and both
showing the same banner error(s). Sticking with snackbar errors in this case
until we have contextual banner errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
