scottyaslan commented on code in PR #8707:
URL: https://github.com/apache/nifi/pull/8707#discussion_r1583802012
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/styles/_listing-table.scss:
##########
@@ -110,15 +120,15 @@
}
tr:hover {
- background-color: $surface-highlight !important;
+ background-color: $highlight-surface;
}
.selected {
- background-color: $selected-row-color !important;
+ background-color: $highlight-surface !important;
Review Comment:
Ok yea, James also just pointed this out. It is especially tricky since we
have the `unset` values in the properties table as well. His suggestion was to
remove the even styles for the `.listing-table`'s and just have the lighter or
darker nifi surface palette be the selected style depending on light/dark mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
