[
https://issues.apache.org/jira/browse/NIFI-3266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15786277#comment-15786277
]
ASF GitHub Bot commented on NIFI-3266:
--------------------------------------
GitHub user ddewaele opened a pull request:
https://github.com/apache/nifi/pull/1373
NIFI-3266 Added EL support for basePath and port in ListenHTTP
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/IxorTalk/nifi nifi-3266
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1373.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1373
----
commit d4c804000386db5b4689e948df7718aabbade696
Author: Davy De Waele <[email protected]>
Date: 2016-12-29T22:24:21Z
NIFI-3266 Added EL support for basePath and port in ListenHTTP
----
> ListenHTTP Processor should support EL for basePath and port
> ------------------------------------------------------------
>
> Key: NIFI-3266
> URL: https://issues.apache.org/jira/browse/NIFI-3266
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Configuration Management
> Affects Versions: 1.0.0, 1.1.0, 1.1.1
> Reporter: Davy De Waele
>
> ListenHTTP should support expression language (without a flow file) for
> basePath and port in order to make use of the variable registry and reference
> different paths and ports per environment.
> Relevant code :
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListenHTTP.java#L80#L93
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
