martinzink commented on code in PR #1776: URL: https://github.com/apache/nifi-minifi-cpp/pull/1776#discussion_r1587692280
########## docker/centos/Dockerfile: ########## Review Comment: Reverted the centos7 removal, but without testing that will probably break in the future. (but centos7 eol is already upon us so thats might not be an issue) ########## docker/focal/Dockerfile: ########## Review Comment: Its not tested and it seems broken since ~2023.06. I've refreshed the README.md so it communicates clearly that instead of multiple docker builds we now recommend building a distro-agnostic binary. https://github.com/apache/nifi-minifi-cpp/pull/1776/commits/4ab03d512124bef024e97ce3af7364a0f43a09a6#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R500 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
