rfellows commented on code in PR #8724:
URL: https://github.com/apache/nifi/pull/8724#discussion_r1588080597
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/property-table/property-table.component.ts:
##########
@@ -215,18 +220,50 @@ export class PropertyTable implements AfterViewInit,
ControlValueAccessor {
return false;
}
+ // if the dependent item is sensitive, in this case we are lenient and
+ // consider the dependency met
+ if (dependentItem.descriptor.sensitive) {
+ return true;
+ }
+
// if the dependent item is visible, but does not require a specific
// dependent value consider the dependency met
if (this.nifiCommon.isEmpty(dependency.dependentValues)) {
Review Comment:
We need to handle the scenario where the dependentItem.value is null so the
dependency is not shown. An example of this is the
`AWSCredentialsProviderControllerService` and the `Assume Role ARN` property.
If it is unset, the other properties below it should not be shown (like `Assume
Role Session Name` among others).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
