mcgilman commented on code in PR #8733:
URL: https://github.com/apache/nifi/pull/8733#discussion_r1589296525


##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/edit-parameter-dialog/edit-parameter-dialog.component.ts:
##########
@@ -163,8 +166,8 @@ export class EditParameterDialog {
         this.editParameter.next({
             parameter: {
                 name: this.editParameterForm.get('name')?.value,
-                value,
-                valueRemoved: value == '' && !empty,
+                value: value === '' && !empty ? null : value,
+                valueRemoved: value === '' && !empty,

Review Comment:
   When applying the Parameter Context update, this `valueRemoved` field is 
getting lost and doesn't not get included in the update request. As a result, 
it's not possible when the user attempts to clear a field it is not removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to