exceptionfactory commented on code in PR #8738:
URL: https://github.com/apache/nifi/pull/8738#discussion_r1589322962
##########
nifi-framework-api/src/main/java/org/apache/nifi/bootstrap/BootstrapCommunicator.java:
##########
@@ -25,11 +25,13 @@ public interface BootstrapCommunicator {
/**
* Sends a command with specific arguments to the bootstrap process
+ *
* @param command the command to send
- * @param args the args to send
+ * @param args the args to send
+ * @return whether the command send was successful or not
* @throws IOException exception in case of communication issue
*/
- void sendCommand(String command, String... args) throws IOException;
+ boolean sendCommand(String command, String... args) throws IOException;
Review Comment:
For future flexibility, I recommend changing the `boolean` to an `enum`
named something like `CommandResult` or `CommandStatus`. The initial values
could be `FAILURE` and `SUCCESS`, but using an `enum` provides more options for
extension with changing the interface contract.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
