james-elliott commented on code in PR #8745:
URL: https://github.com/apache/nifi/pull/8745#discussion_r1591427122
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/_canvas.component-theme.scss:
##########
@@ -90,6 +90,11 @@
/*
All components
*/
+
+ g.component {
+ font-family: mat.get-theme-typography($material-theme, body-1,
font-family);
+ }
+
Review Comment:
You call mat.get-theme-typography() 4 times in this file to request "body-1"
could you call it once and store it as a variable to re-use?
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/styles.scss:
##########
@@ -54,7 +50,7 @@
// To override the canvas theme, you need to set the variables
$nifi-theme-light and $nifi-theme-dark
@import 'assets/themes/nifi';
// To override the NiFi theme, you need to set the variables
$material-theme-light and $material-theme-dark
-@import 'assets/themes/material';
+@import 'assets/themes/purple';
Review Comment:
I'm sure you meant to leave this as the Material theme by default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
