[
https://issues.apache.org/jira/browse/NIFI-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15794930#comment-15794930
]
ASF GitHub Bot commented on NIFI-2908:
--------------------------------------
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/1381
NIFI-2908 Added TimeZone to toDate() and format() EL
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pvillard31/nifi NIFI-2908
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1381.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1381
----
commit 92336f0551516cf2d2ea9c9e6b1b2a235f1a1c62
Author: Pierre Villard <[email protected]>
Date: 2017-01-03T12:16:40Z
NIFI-2908 Added TimeZone to toDate() and format() EL
----
> Add TimeZone support to EL date functions
> -----------------------------------------
>
> Key: NIFI-2908
> URL: https://issues.apache.org/jira/browse/NIFI-2908
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Reporter: Dave Torok
> Priority: Minor
>
> Currently the toDate() and format() functions under the hood use a
> SimpleDateFormat with the current system timezone. This leads to hard to
> locate data inconsistency errors when parsing and then generating date
> strings when the date strings are not in the same or current time zone.
> Even the example given in the documentation
> ${time:format("yyyy/MM/dd HH:mm:ss.SSS'Z'")}
> will give an incorrect output when the system timezone is not set to GMT.
> suggestion is to add a variant to toDate(String tz) and format(String tz)
> which accepts a timezone of Java nomenclature which can be set with
> "SimpleDateFormat.setTimeZone(TimeZone.getTimeZone(tz))"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
