[ 
https://issues.apache.org/jira/browse/NIFI-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15795448#comment-15795448
 ] 

ASF GitHub Bot commented on NIFI-3231:
--------------------------------------

Github user bbende commented on the issue:

    https://github.com/apache/nifi/pull/1361
  
    Looks good, was able to use EL for all three processors modified. 
    
    While testing this I noticed that PutUDP does not report a SEND event for 
provenance. It would likely be a small fix to make PutUDP do this in onTrigger:
    
    ```
    StopWatch stopWatch = new StopWatch(true);
    sender.send(content.toByteArray());
    session.getProvenanceReporter().send(flowFile, transitUri, 
stopWatch.getElapsed(TimeUnit.MILLISECONDS));
    ```
    Do you want to add that to this PR, or we can create another JIRA since 
technically it is an existing problem?


> PutTCP and PutUDP should support EL for host and port
> -----------------------------------------------------
>
>                 Key: NIFI-3231
>                 URL: https://issues.apache.org/jira/browse/NIFI-3231
>             Project: Apache NiFi
>          Issue Type: Improvement
>    Affects Versions: 1.0.0, 1.1.0, 1.1.1
>            Reporter: Bryan Bende
>            Assignee: Pierre Villard
>
> PutTCP and PutUDP should support expression language (without a flow file) 
> for host and port in order to make use of the variable registry and reference 
> different hosts and ports per environment.
> Relevant code:
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutTCP.java#L110
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutUDP.java#L94



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to