scottyaslan commented on code in PR #8837:
URL: https://github.com/apache/nifi/pull/8837#discussion_r1603633315
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/items/flow/change-version-dialog/change-version-dialog.html:
##########
@@ -22,32 +22,48 @@ <h2 mat-dialog-title>
<mat-dialog-content>
<div class="dialog-content flex flex-col gap-y-4 w-full">
<div class="flex flex-row w-full">
- <div class="flex flex-1 flex-col gap-y-4">
+ <div class="flex w-1/2 flex-col gap-y-4 overflow-hidden">
Review Comment:
Total nit pick here but we don't need overflow-hidden here:
```suggestion
<div class="flex w-1/2 flex-col gap-y-4">
```
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/items/flow/change-version-dialog/change-version-dialog.html:
##########
@@ -22,32 +22,48 @@ <h2 mat-dialog-title>
<mat-dialog-content>
<div class="dialog-content flex flex-col gap-y-4 w-full">
<div class="flex flex-row w-full">
- <div class="flex flex-1 flex-col gap-y-4">
+ <div class="flex w-1/2 flex-col gap-y-4 overflow-hidden">
<div>
<div>Registry</div>
- <div class="accent-color font-medium">{{
versionControlInformation.registryName }}</div>
+ <div
+ class="accent-color font-medium overflow-ellipsis
overflow-hidden whitespace-nowrap"
+ [title]="versionControlInformation.registryName">
+ {{ versionControlInformation.registryName }}
+ </div>
</div>
<div>
<div>Bucket</div>
- <div class="accent-color font-medium">{{
versionControlInformation.bucketName }}</div>
+ <div
+ class="accent-color font-medium overflow-ellipsis
overflow-hidden whitespace-nowrap"
+ [title]="versionControlInformation.bucketName">
+ {{ versionControlInformation.bucketName }}
+ </div>
</div>
</div>
- <div class="flex flex-1 flex-col gap-y-4">
+ <div class="flex w-1/2 pl-2 flex-col gap-y-4 overflow-hidden">
Review Comment:
```suggestion
<div class="flex w-1/2 pl-2 flex-col gap-y-4">
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
