[
https://issues.apache.org/jira/browse/NIFI-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15798460#comment-15798460
]
ASF GitHub Bot commented on NIFI-3260:
--------------------------------------
Github user apiri commented on the issue:
https://github.com/apache/nifi/pull/1372
I think the tags should be fine and it is okay to continuously version the
one, true Dockerfile with each release. From a release perspective, it would
be on the RM to kick off the various processes that would generate a build with
the new tag, but our core, source release is the Dockerfile and whatever
periphery we may choose to include (in future releases, this could include
things like compose files). We could likely additionally make use of maven
filtering to have the needed versions get updated.
Insofar as tagging/versions, I have taken a similar approach with the image
I have been maintaining: https://hub.docker.com/r/aldrin/apache-nifi/tags/.
Upon each update, I tag that source and push both that commit and tag to the
repository. This manifests itself as the latest version being tagged latest
and its respective version. When a new version comes out, latest is advanced
to correspond to the same image generated from the new tag.
For the official repo as provided, we could just add the new version to
that list and keep it there as long as supported. Given our release structure,
this seems to coincide pretty well with the guidance provided at
https://github.com/docker-library/official-images#library-definition-files. As
certain versions become obsolete/unsupported, those associated entries would be
purged. I think this also allows us to get away from the directory structure
as every release we perform will have a new commit which we can reference
whilst keeping a consistent path to the Dockerfile.
> Official Docker Image
> ---------------------
>
> Key: NIFI-3260
> URL: https://issues.apache.org/jira/browse/NIFI-3260
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Tools and Build
> Reporter: Jeremy Dyer
> Assignee: Jeremy Dyer
>
> This JIRA is for setting up a Docker folder structure within the NiFi source
> code as discussed in the dev mailing list at
> https://lists.apache.org/thread.html/e905a559cb01b30f1a7032cec5c9605685f27a65bdf7fee41b735089@%3Cdev.nifi.apache.org%3E
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
