dan-s1 commented on code in PR #8691: URL: https://github.com/apache/nifi/pull/8691#discussion_r1608719446
########## nifi-extension-bundles/nifi-network-bundle/nifi-network-processors-nar/src/main/resources/META-INF/NOTICE: ########## @@ -4,6 +4,12 @@ Copyright 2017-2020 The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://www.apache.org/). +This project includes derived works from the Kaitai Project available under the MIT License. + Portions of code found at https://formats.kaitai.io/pcap/java.html + Copyright 2015-2023 Kaitai Project + The code can be found in: + nifi-nar-bundles/nifi-network-bundle/nifi-network-processors/util/PCAP.java + nifi-nar-bundles/nifi-network-bundle/nifi-network-processors/util/Linktype.java Review Comment: The paths have changed, `PCAP` has been broken down to different files, `LinkType` has been removed and the copyright year should reflect the current year hence the following changes should be made.. ```suggestion Copyright 2015-2024 Kaitai Project The code can be found in: nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/pcap/ByteBufferInterface.java nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/pcap/Header.java nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/pcap/PCAP.java nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/pcap/Packet.java ``` @exceptionfactory Can you please advise whether this information belongs in this file only, in the top level `NOTICE` file only or in both? ########## nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/pcap/PCAP.java: ########## @@ -0,0 +1,161 @@ +// MIT License + +// Copyright (c) 2015-2023 Kaitai Project Review Comment: ```suggestion // Copyright (c) 2015-2024 Kaitai Project ``` ########## nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/pcap/Packet.java: ########## @@ -0,0 +1,98 @@ +// MIT License + +// Copyright (c) 2015-2023 Kaitai Project Review Comment: ```suggestion // Copyright (c) 2015-2024 Kaitai Project ``` ########## nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/pcap/Header.java: ########## @@ -0,0 +1,151 @@ +// MIT License + +// Copyright (c) 2015-2023 Kaitai Project Review Comment: ```suggestion // Copyright (c) 2015-2024 Kaitai Project ``` ########## nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/pcap/ByteBufferInterface.java: ########## @@ -0,0 +1,87 @@ +// MIT License + +// Copyright (c) 2015-2023 Kaitai Project Review Comment: ```suggestion // Copyright (c) 2015-2024 Kaitai Project ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
