[
https://issues.apache.org/jira/browse/NIFI-2839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15798562#comment-15798562
]
ASF GitHub Bot commented on NIFI-2839:
--------------------------------------
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1384
The code changes look good. Will have @andrewmlim review as well since he
created the JIRA. May need to update some wording for consistency throughout
the application. For instance, template deletion is similar but uses different
wording.
Also, if a Controller Service is scoped within a Process Group, deleting
the Process Group will also delete the Controller Service. I do not think we
need to prompt in this case as I believe the original issue was due to the
mechanics of deleting being initiated from a button in the table. If we decide
we need to do anything regarding the deletion of a Process Group, I think we
should address it in a follow-on JIRA.
> Add a confirmation dialog when deleting a Controller Service
> ------------------------------------------------------------
>
> Key: NIFI-2839
> URL: https://issues.apache.org/jira/browse/NIFI-2839
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core UI
> Affects Versions: 1.0.0
> Reporter: Andrew Lim
> Assignee: Pierre Villard
> Priority: Minor
> Labels: UI
>
> As soon as the user selects a Controller Service for deletion it is
> immediately deleted. There should be a warning/confirmation dialog to make
> sure this is the user's intended selection/action.
> This is especially needed because it is possible in the UI to create
> Controller Services with the same name, so it can be ambiguous which one is
> being selected for deletion.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
